perf: Don't fetch all users from a group on login - #1231
Merged
Merged
Conversation
come-nc
approved these changes
Sep 10, 2026
CarlSchwan
force-pushed
the
carl/login-perf
branch
from
September 10, 2026 10:05
00507b1 to
df40524
Compare
Instead of fetching all users from a group to then check if they are in the saml backend. Do directly a join on the saml user table. This should fix the multiple thousands of DB requests created on any SAML logins. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/login-perf
branch
from
September 10, 2026 10:11
df40524 to
5061b59
Compare
Member
Author
|
Fix #1194 btw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of fetching all users from a group to then check if they are in the saml backend. Do directly a join on the saml user table.
This should fix the multiple thousands of DB requests created on any SAML logins.
🤖 AI (if applicable)