fix(tests): toggle link providers by their switch role - #2988
Open
AndyScherzinger wants to merge 1 commit into
Open
fix(tests): toggle link providers by their switch role#2988AndyScherzinger wants to merge 1 commit into
AndyScherzinger wants to merge 1 commit into
Conversation
AndyScherzinger
force-pushed
the
fix/text-link-plain-url-render-race
branch
from
September 8, 2026 06:20
c45393c to
da1c6c4
Compare
AndyScherzinger
changed the title
AndyScherzinger
force-pushed
the
fix/text-link-plain-url-render-race
branch
from
September 8, 2026 06:36
da1c6c4 to
25e9525
Compare
AndyScherzinger
changed the title
createTextLinkColumn() looked the "Allowed types" provider toggles up
with getByRole('checkbox'), but they expose the switch role, so the
locator matched nothing and setCheckboxState() returned without
toggling. Every pre-activated provider stayed enabled, so a URL only
column rendered the provider NcSelect instead of the plain text field
and the value typed by the test was never committed, leaving the row
without it. The toggles are now addressed by their switch role and the
requested provider is asserted to exist, so a future role change fails
the test instead of silently disabling the column setup.
Assisted-by: ClaudeCode:claude-opus-5
Claude-Session: https://claude.ai/code/session_015aqLZ5g2YsrewxS9UQcuwJ
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
fix/text-link-plain-url-render-race
branch
from
September 8, 2026 06:59
25e9525 to
d7890a6
Compare
AndyScherzinger
marked this pull request as ready for review
September 8, 2026 07:52
AndyScherzinger
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createTextLinkColumn()looked the "Allowed types" provider toggles up withgetByRole('checkbox', …), but the accessibility tree shows they expose the switch role, so the locator matched nothing andsetCheckboxState()returned without toggling anything. Every pre-activated provider therefore stayed enabled (preActivatedProvidersisurl, files, contacts), so a URL-only column rendered the providerNcSelectinstead of the plainNcTextField, the value typed by.fill()went into the select's search box and was never committed, and the row saved without it - which is whycolumn-text-link.spec.ts:16fails onmainacross all four Nextcloud versions.The toggles are now addressed by their switch role and the requested provider is asserted to exist, so a future role change fails the test loudly instead of silently disabling the column setup.
This is a test-side fix only; no application code is touched.
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)