fix(import): avoid crash when table or view is deleted before import job runs - #2987
Open
silverkszlo wants to merge 2 commits into
Open
fix(import): avoid crash when table or view is deleted before import job runs#2987silverkszlo wants to merge 2 commits into
silverkszlo wants to merge 2 commits into
Conversation
blizzz
approved these changes
Sep 7, 2026
Koc
reviewed
Sep 8, 2026
…job runs Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by:ClaudeCode:claude-opus-5
silverkszlo
force-pushed
the
fix/import-table-job
branch
from
September 10, 2026 12:51
bc307bc to
af0c06b
Compare
benjaminfrueh
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ImportTableJobwas throwing the following error multiple times:If the table (or the view whose table this resolves) is deleted between when the import job is queued and when the background worker picks it up,
TableMapper::find()/ViewMapper::find()throwsDoesNotExistException, which propagates uncaught out ofrun().Wrap the table/view lookup in a try/catch so a deleted table or view is logged as a warning and the import-finished activity is skipped instead of throwing.
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)