Skip to content

feat(dashboard): Show triggered reminders instead of upcoming ones - #19263

Open
nickvergessen wants to merge 1 commit into
mainfrom
feat/noid/show-triggered-reminders-on-dashboard
Open

feat(dashboard): Show triggered reminders instead of upcoming ones#19263
nickvergessen wants to merge 1 commit into
mainfrom
feat/noid/show-triggered-reminders-on-dashboard

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Sep 3, 2026

Copy link
Copy Markdown
Member

☑️ Resolves

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
grafik grafik

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@nickvergessen nickvergessen added this to the ☃️ Next Major (36) milestone Sep 3, 2026
@nickvergessen nickvergessen self-assigned this Sep 3, 2026
@nickvergessen nickvergessen added enhancement feature: dashboard 🏠 Features relating to the Talk internal dashboard labels Sep 3, 2026
@nickvergessen

nickvergessen commented Sep 3, 2026

Copy link
Copy Markdown
Member Author
  • Backend todo: Notice when we render for this list and skip adding Reminder: prefix to the notification subject

@nickvergessen
feat(dashboard): Show triggered reminders instead of upcoming ones
2b317d6 
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessen force-pushed the feat/noid/show-triggered-reminders-on-dashboard branch from 0d656fe to 2b317d6 Compare September 4, 2026 07:29
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Sep 4, 2026
Antreesy
Antreesy reviewed Sep 14, 2026
View reviewed changes

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in pair with notifications companion PR - works nicely, but I'm not fond of losing current feature

Comment thread src/components/Dashboard/TalkDashboard.vue

const supportsUpcomingReminders = hasTalkFeature('local', 'upcoming-reminders')
const supportsReminders = hasTalkFeature('local', 'upcoming-reminders') || supportsTriggeredReminders
const remindersTitle = supportsTriggeredReminders ? t('spreed', 'Reminders') : t('spreed', 'Upcoming reminders')

@Antreesy Antreesy Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder element uses t('spreed', 'Message reminders'), maybe also reuse it here?

Comment thread src/stores/dashboard.ts
async fetchReminders() {
if (supportsTriggeredReminders) {
await this.fetchTriggeredReminders()
} else {

@Antreesy Antreesy Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we keep both lists? Maybe with a divider
I find it useful personally to see future reminders as well

Comment thread src/types/index.ts

@Antreesy Antreesy Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can wire notifications openAPI via src/types/generate-core-types.sh and workflow update, to keep in sync

Comment thread src/stores/dashboard.ts
*
* @param notification A notification with the object type `reminder`
*/
function parseReminderNotification(notification: NotificationsNotification): DashboardReminder {

@Antreesy Antreesy Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move it to src/services/notificationsService.ts or separate util

@nickvergessen

nickvergessen commented Sep 17, 2026

Copy link
Copy Markdown
Member Author

but I'm not fond of losing current feature

My problem is that the current behaviour is a counter-feature and basically preventing to focus. The user decided it's not relevant for now and delayed it. There is no need to continue seeing it.

@DorraJaouad

DorraJaouad commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

but I'm not fond of losing current feature

I also agree. There is no place where the user sees the list of reminders they own. I often see the reminder feature in other apps showing both the upcoming in pale colors and for the triggered ones , they are in highlighted red. It makes sense to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy left review comments
@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

At least 1 approving review is required to merge this pull request.

Assignees

@nickvergessen nickvergessen

Labels

AI assisted This PR contains AI-assisted commits enhancement feature: dashboard 🏠 Features relating to the Talk internal dashboard

Projects

None yet

Milestone

☃️ Next Major (36)

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @DorraJaouad @Antreesy @nextcloud-command