Repository navigation
fix(Router): Load attribute routes of apps not enabled for the current user - #66126
Open
marcelklehr wants to merge 1 commit into
Open
marcelklehr wants to merge 1 commit into
marcelklehr wants to merge 1 commit into
Conversation
…t user When routing a request to a specific app, attribute routes were only loaded if the app is enabled for the current user. For apps restricted to groups this breaks requests that the app authenticates itself after routing (e.g. via custom bearer tokens), because no user is logged in at routing time yet. Routes from routes.php files, loading all routes and the CachingRouter do not have this restriction either. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
requested review from
Altahrim,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
November 1, 2026 15:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When routing a request to a specific app, attribute routes were only loaded if the app is enabled for the current user. For apps restricted to groups this breaks requests that the app authenticates itself after routing (e.g. via custom bearer tokens), because no user is logged in at routing time yet. Routes from routes.php files, loading all routes and the CachingRouter do not have this restriction either.
Specific issue in the bookmarks app: An admin has restricted the bookmarks app to a certain group, but some public routes still need to be accessible even when nobody is logged in.
Checklist
3. to review, feature component)stable32)AI (if applicable)