Repository navigation
Conversation
skjnldsv
force-pushed
the
feature/share-lookup-by-file-ids
branch
from
October 15, 2026 07:17
07e5260 to
6588755
Compare
IManager::getSharesByNodes() and getSharedWithByNodes() return the shares of a list of nodes, the same as calling getSharesBy() and getSharedWith() for each node. Share providers implementing IShareProviderSupportsFileIds answer with one query for all the files, the default, mail and federated providers do. Other providers are still asked file by file. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
feature/node-attribute-shares
branch
from
October 16, 2026 16:15
6b20b0a to
36ce3a2
Compare
skjnldsv
force-pushed
the
feature/share-lookup-by-file-ids
branch
from
October 16, 2026 16:15
6588755 to
d33c068
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IManager::getSharesByNodes()andgetSharedWithByNodes()return the shares of a list of nodes, the same as callinggetSharesBy()andgetSharedWith()for each node. Share providers implementing the newIShareProviderSupportsFileIdsanswer with one query for all the files: the default, mail and federated providers do. Other providers (Talk, Circles, Deck) are still asked file by file until they implement it.SharesProviderfrom #65400 uses it, soshare-typesandshareescost 13 queries on the share table for any number of nodes instead of 13 per node. Folder listings keepgetSharesInFolder().Measured on an account with 70k files and 5,500 received shares, median of 5 rounds:
The answers are the same as before for all 31 Files app properties, compared on Recent, Favorites, listings and single files. A DB test checks the bulk lookup against the per-file calls.
ManagerTest, DefaultShareProviderTest, sharebymail, federatedfilesharing, dav and files_sharing Controller tests pass locally. Psalm not run locally.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.