Repository navigation
[stable35] perf: Improve preview cold generation - #65451
Open
backportbot[bot] wants to merge 2 commits into
Open
backportbot[bot] wants to merge 2 commits into
backportbot[bot] wants to merge 2 commits into
Conversation
backportbot
Bot
requested review from
CarlSchwan,
icewind1991 and
salmart-dev
October 13, 2026 07:57
backportbot
Bot
added
3. to review
When the max preview was just generated, its image is still in memory. Use it to resize the requested preview instead of reading the stored max preview back and decoding it again, which for a 12 MP photo takes a few hundred milliseconds. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
New preview sizes were always resized from the max preview, so each one paid for decoding and resampling the full resolution image. Use the smallest cached, uncropped preview that is still larger than the requested size as the source instead, e.g. the 256px grid view preview for the 64px list view one. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
marked this pull request as ready for review
October 14, 2026 08:01
CarlSchwan
force-pushed
the
backport/65146/stable35
branch
from
October 14, 2026 08:02
dfaa240 to
2261877
Compare
CarlSchwan
approved these changes
Oct 14, 2026
Merged
icewind1991
approved these changes
Oct 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #65146
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.