Repository navigation
perf(dav): only create the calendar reminder providers when used - #65429
Closed
CarlSchwan wants to merge 1 commit into
Closed
CarlSchwan wants to merge 1 commit into
CarlSchwan wants to merge 1 commit into
Conversation
Instead of instanciating then for each requests, do it only when needed. This saves about 0.5ms on every request, around 3% of a request with almost no work of its own. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
requested review from
ChristophWurst,
SebastianKrupinski and
tcitworld
as code owners
October 12, 2026 15:11
come-nc
reviewed
Oct 12, 2026
come-nc
left a comment
come-nc
left a comment
Contributor
There was a problem hiding this comment.
That’s only on PHP<8.4, no? On 8.4 you get a ghost anyway?
Member
Author
We are doing |
Member
Author
|
Actually I was running on php 8.3, with php 8.5 the difference is not worth it |
Contributor
I wanted to do that initially, because usually when doing Server::get it’s because you’re gonna use the class anyway, but I never did that, because it was complicated to properly differentiate this with DI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instead of instantiating then for each requests, do it only when needed.
This saves about 0.5ms on every request, around 3% of a request with almost no work of its own.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)