Repository navigation
fix(mail): embed image logo only when using useTemplate - #65422
Merged
Merged
Conversation
The reason for this is that the change that introduced the embedded logo broke the logo for all apps that did not call useTemplate. This change uses the logo url by default and replaces it with cid:logo only when the image is actually attached to the mail. Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com> Assisted-by: ClaudeCode:claude-opus-5-5
salmart-dev
force-pushed
the
fix/embedded-logo
branch
from
October 12, 2026 13:51
41e2de0 to
382f73d
Compare
salmart-dev
marked this pull request as ready for review
October 12, 2026 13:53
salmart-dev
requested review from
icewind1991,
leftybournes,
provokateurin and
sorbaugh
and removed request for
a team
October 12, 2026 13:53
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
CarlSchwan
approved these changes
Oct 12, 2026
susnux
approved these changes
Oct 12, 2026
This was referenced Oct 12, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useTemplate) #64957Summary
A regression introduced by #62933 left emails from apps that do not use
IMessage::useTemplatewithout a Nextcloud logo. This PR uses the logo URL by default and replaces it withcid:logoonly when the image needs to be attached to the mail and is found in$inlineImages.NOTE: backports need to get a corrected
@sinceannotation also for the changes introduced in #62933Checklist
3. to review, feature component)stable32)AI (if applicable)