Repository navigation
Conversation
CarlSchwan
approved these changes
Oct 12, 2026
come-nc
marked this pull request as ready for review
October 12, 2026 15:27
come-nc
requested review from
icewind1991,
leftybournes,
salmart-dev and
sorbaugh
and removed request for
a team
October 12, 2026 15:27
come-nc
added
3. to review
Parameters flagged with this attribute are now handled like methods flagged as sensitive in Nextcloud: Their value is stacktraces is replace with the same placeholder (instead of '[class => SensitiveParameterValue]'). And their value is tracked and removed from the rest of the stacktrace. Meaning if another function is called on the parameter it gets removed there as well. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
feat/add-support-for-sensitiveparameter
branch
from
October 12, 2026 15:29
03509fd to
db486e4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parameters flagged with this attribute are now handled like methods flagged as sensitive in Nextcloud: Their value is stacktraces is replace with the same placeholder (instead of '[class => SensitiveParameterValue]'). And their value is tracked and removed from the rest of the stacktrace. Meaning if another function is called on the parameter it gets removed there as well.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)