Repository navigation
Conversation
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
4 of 7 tasks
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
marked this pull request as ready for review
September 26, 2026 15:39
Koc
requested review from
Altahrim,
CarlSchwan,
come-nc and
provokateurin
and removed request for
a team
September 26, 2026 15:39
Member
|
What is the usecase? |
Contributor
Author
|
@CarlSchwan please check linked issue nextcloud/collectives#2743 in Collective app |
come-nc
reviewed
Oct 5, 2026
come-nc
left a comment
come-nc
left a comment
Contributor
There was a problem hiding this comment.
I do not understand why the refactor in QueryBuilder and Connection.
You only needed support for insertIgnoreConflict in the Mapper, no?
It was already supported in the query builder.
Contributor
|
Also why is insertOrUpdate not enough? |
… (code review) Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/insert-ignore-conflicts
branch
from
October 12, 2026 21:43
486803a to
55316e7
Compare
Contributor
Author
|
@come-nc I've simplified PR and updated description with an explanation |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
QBMapper::insertIgnoreConflict()to insert entities while ignoring conflicts. UnlikeinsertOrUpdate(), it leaves existing rows unchanged and avoids PostgreSQL duplicate-key error logs for expected conflicts. Use case can be found at nextcloud/collectives#2743Checklist
3. to review, feature component)stable32)AI (if applicable)