fix: hanging test in direct.spec.js - #5972
Conversation
Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Nextcloud 35 uses modifyColumn instead of changeColumn Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
0e85d9d to
a489668
Compare
|
Save-As test regains its hang-fix but drops an assertion it doesn't need to drop.
The fix is already established in this repo: cy.waitForPostMessage('Action_Save_Resp', { success: true, fileName: exportFilename })Suggest mirroring that here instead of dropping the check entirely: - cy.get('@loleafletframe').within(() => {
- cy.verifyOpen('document.rtf')
- })
+ cy.waitForPostMessage('Action_Save_Resp', { success: true, fileName: 'document.rtf' })
(Everything else in the PR — the migration |
Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
moodyjmz
left a comment
There was a problem hiding this comment.
Fix applied exactly as suggested (fileName assertion restored). All three changes verified against actual repo/runtime behavior — LGTM.
Fixes hanging tests in
direct.spec.jsbecause the sessions were not being cleared properly, and fixes a psalm error regarding a change to OCP.Assisted-by: ClaudeCode:claude-sonnet-4-6
Checklist