feat: type script definitions - #1094
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
SebastianKrupinski
added
3. to review
| "@nextcloud/axios": "^2.6.0" | ||
| } | ||
| }, | ||
| "types": "./dist/index.d.ts" |
There was a problem hiding this comment.
| "types": "./dist/index.d.ts" | |
| "types": "dist/index.d.cts" |
To be consistent with "main": dist/index.cjs",
There was a problem hiding this comment.
Reverted this, applying it breaks type generation. vite-plugin-dts (with rollupTypes: true) reads package.json's types field to decide where to write the rolled-up declaration bundle. Pointing types at dist/index.d.cts makes it target that file directly, and the rollup step silently produces an empty stub (export {}) for a .d.cts target instead of real declarations
odzhychko
left a comment
odzhychko
left a comment
There was a problem hiding this comment.
Needs https://github.com/nextcloud/cdav-library/pull/1094/changes#r4070835767 for consistency.
Rest works as expected.
4242f5d to
3027c7b
Compare
3027c7b to
ea65114
Compare
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
ea65114 to
dca8a7a
Compare
github-project-automation
Bot
moved this from 🏗️ In progress
to ☑️ Done
in 💌 📅 👥 Groupware team
2 participants
Summary
🤖 AI (if applicable)