Repository navigation
Neos 9 support - #1
Merged
Merged
Conversation
Notes: - verified green on Neos 8.4 with PHPUnit 9.6 and on Neos 9.2 with PHPUnit 11.5
Why: - copied Media Browser edit template is unchanged in Neos 9.2 apart from the added partial, so no template variant per Neos version Notes: - smoke-tested on Neos 9.2 with MySQL 8: migration, saving in media module and standalone media browser, Eel helper, cache flush - CI still only covers Neos 8; a Neos 9 job is follow-up work
Why: - without a lock file composer resolves the newest dev tools, so Neos 8 jobs pin PHPUnit 9 to keep testing what Neos 8 projects use Notes: - both jobs reproduced locally on PHP 8.4 with the same composer commands; the other matrix PHP versions only run on GitHub Actions Issue: neos-9
Issue: neos-9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neos 9 support
Allows installing the package on Neos 9 (
^8.3 || ^9.0forneos/neos,neos/media-browser,neos/fusion).The package code itself needs no changes. The copied Media Browser edit template (
Resources/Private/Templates/Asset/Edit.html) is identical to the Neos 8.4 and 9.2 templates apart from the addedAiClassificationpartial, so one template serves both versions.Test changes
Two unit tests did not run with the Neos 9 dependency set:
AssetAiClassificationMigrationTest::assetIdentifierEncodings()is nowstatic. PHPUnit 10+ requires static data providers.AssetAiClassificationRepositoryTestbuilds itsDoctrine\ORM\Configurationby hand.Doctrine\ORM\Tools\Setup::createConfiguration()needsdoctrine/cache1.11 orsymfony/cache, which a Neos 9 installation does not include.require-devnow allowsphpunit/phpunit ~9.1 || ~11.5andneos/buildessentials ~8.3.0 || ~9.0.CI
neos/contentgraph-doctrinedbaladapter. Neos 9 is only installable with a package that providesneos/contentrepositoryregistry-storageclient.Edit.html, minus thef:renderline, against the installed Media Browser template, so a template change in a future Neos version fails the build. The README section "Supporting a new Neos version" describes this.Verification
AssetControllerandImageController.doctrine:migratecreates the table with the unique key and the foreign key.AssetAiClassification.getClassification()returns the saved value in Fusion.