Repository navigation
Build only one Usage & Spend summary at a time #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
coolkillercat
wants to merge
1
commit into
nesszer:main
Choose a base branch
from
coolkillercat:fix/usage-spend-single-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not return a cached summary built under a different privacy setting.
While a build is active, the non-forced fallback in
claim_buildreturns the cached summary without comparing its key. The cache key includeshide_personal_info, but this branch ignores that value. If the cached summary was built with privacy off, a request made after Hide personal information is enabled can receive unredacted data. Redaction happens only when the contract is constructed inrust/src/spend_contract.rs, and this command does not redact the reused summary again.Apply the privacy check in the fallback. Reuse a stale summary only when its privacy setting matches the request. Otherwise return
Waitor build a new summary. Alternatively, redact the reused summary before it is returned.Do not reuse a cached summary for a different reporting period.
When a build is running, the non-forced fallback in
claim_buildreturns the cached summary without comparing its key. If the cache holds a 30-day summary and the user selects 7 days, the request receives the 30-day data. It does not wait for or start a 7-day build.UsageSpendTabdisplays the response'sreportingPeriod, so the wrong period appears without a warning. The stale result lasts until the active build finishes and the user requests again.Limit the fallback to stale provider revisions for the same reporting period. For a different period, wait for the active build and then build the requested period.