fix: populate JobDetail identification form when disc is auto-detected - #103
Merged
Conversation
Fixes #67 and #69. When a movie/disc was auto-detected while the JobDetail page was open, the identification form stayed empty: only the H1/poster updated via SignalR, while the Title/Year/Video Type/IMDb/Season/Disc/Poster cells kept showing placeholder dashes. - Extend JobUpdate with the auto/final identification fields so the SignalR payload carries them after IdentifyService completes - Give the identification form cells stable ids and live-populate the Auto/Final columns in JobDetail.cshtml (manual inputs untouched) - Swap the Approve Title / Clear Approval buttons once HasNiceTitle lands - Add JobUpdateTests for the mapping and a WebUi test asserting the identification markup the live-update JS depends on
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67 and #69.
Problem
When a movie/disc is auto-detected while the JobDetail page is open, the
identification form stays empty. The SignalR
JobUpdatehandler only refreshedthe H1, poster, progress and disc-type — the identification form's Auto and
Final columns for Title, Year, Video Type, IMDb ID, Season, Disc, Starting
Episode and Poster URL kept showing placeholder dashes, so:
Fix
JobUpdatenow carries the auto/final identification fields(
TitleAuto,YearAuto,VideoTypeAuto,VideoType,ImdbIdAuto,PosterUrlAuto,SeasonNumber(Manual/Auto),DiscNumber(Manual/Auto),StartingEpisodeNumber,HasNiceTitle) so the SignalR payload reflectswhat
IdentifyServicepersisted.JobDetail.cshtmlgives the identification form cells stable ids andlive-populates the Auto/Final columns as soon as the update arrives. Manual
inputs are left untouched so the user can still edit/override them.
HasNiceTitlelands from autodetection.Tests
JobUpdateTests:FromJobmaps the identification fields (identified + unidentified cases)Verification
dotnet build— 0 warnings, 0 errors