Discard packets smaller than header offset to prevent slicing panic - #94
Open
SajjadPourali wants to merge 2 commits into
Open
SajjadPourali wants to merge 2 commits into
SajjadPourali wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The regression test can intermittently coalesce writes and fail to exercise the intended discard path.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Prevents panics when Unix packet-information headers are incomplete by discarding undersized reads and adds regression coverage.
Changes:
- Discards reads no larger than the configured header offset.
- Adds a Unix async test for undersized packet data.
File summaries
| File | Description |
|---|---|
src/lib.rs |
Adds short-read handling and regression testing. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| builder.write(&mut packet_data, &[1, 2, 3, 4]).unwrap(); | ||
|
|
||
| peer.write_all(&[0x00, 0x01]).await.unwrap(); | ||
| tokio::task::yield_now().await; |
Contributor
There was a problem hiding this comment.
Fixed in b83c54b by replacing the duplex/yield sequencing with a deterministic chunked test device that returns the malformed 2-byte input and then the valid packet in separate reads.
Co-authored-by: SajjadPourali <20374762+SajjadPourali@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.