Skip to content

fix: guard mzenumeration column check in _merge_filter_cardinality for MS1 data #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhi-0203 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: guard mzenumeration column check in _merge_filter_cardinality for MS1 data #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions massql/msql_engine_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,10 @@ def _merge_filter_cardinality(condition, ms_df_list):
# Figuring out the scans
ms_peak_df = pd.concat(ms_df_list)

if "mzenumeration" not in ms_peak_df.columns:
# MS1 data does not have per-peak enumeration — cardinality filtering is not applicable
return ms_peak_df

enumeration_df = ms_peak_df.groupby(["scan", "mzenumeration"]).first().reset_index()
enumeration_df = enumeration_df.groupby(["scan"]).count()
enumeration_df = enumeration_df[enumeration_df["mzenumeration"] >= min_cardinality]
Expand Down