Skip to content

Idea to remove swizzling #1

Open

Description

@malhal

Just thought I'd share an idea that if you used UIViewControllerRepresentable instead of UIViewRepresentable you could handle disappearing without having to swizzle and you wouldn't need to search for nearest VC either. Similar to MyViewController in this code I posted to Stackoverflow, before I found your library (which I found via this blog btw)

I think Apple call theirs PresentationHostingController.

Activity

  1. mtzaquia commented on Oct 19, 2022

    @mtzaquia
    Owner

    Hey @malhal! Thank you for the tip.

    I haven't been able to support this as much as I would like - there are some missing features I would love to get done here...

    Meanwhile, if you ever get this implementation done without swizzling, I would be super happy to look into your PR and merge this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions