Skip to content

Feature/seperate phylowgs with resume support - #254

Merged
nikhil merged 17 commits into
developfrom
feature/seperate_phylowgs_with_resume_support
Sep 8, 2026
Merged

nikhil merged 17 commits into
developfrom
feature/seperate_phylowgs_with_resume_support

Conversation

@nikhil

@nikhil nikhil commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • Check to see if a nf-core module, or subworkflow is available and usable for your pipeline.
  • Feature branch is named feature/<module_name> for modules, or feature/<subworkflow_name> for subworkflows. For modules, if there is a subcommand use: feature/<module_name>/<module_subcommand>.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs.
  • Use nf-core data if possible for nf-tests. If not, use or add test data to mskcc-omics-workflows/test-datasets, following the repository guidelines, for nf-tests. Finally, if neither option is feasible, only add a stub nf-test.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label.
  • Use Jfrog if possible to fulfill software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <module_branch> test <MODULE> --profile docker
      • nf-core modules --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <module_branch> test <MODULE> --profile singularity
      • nf-core modules --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <module_branch> test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <subworkflow_branch> test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <subworkflow_branch> test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <subworkflow_branch> test <SUBWORKFLOW> --profile conda

@nikhil
nikhil requested a review from a team as a code owner August 11, 2026 19:30
@nikhil
nikhil requested a review from johnoooh August 11, 2026 19:31
@nikhil
nikhil requested a review from pintoa1-mskcc as a code owner August 26, 2026 20:19

@johnoooh johnoooh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@nikhil
nikhil merged commit b0c3c79 into develop Sep 8, 2026
17 checks passed
@nikhil
nikhil deleted the feature/seperate_phylowgs_with_resume_support branch September 8, 2026 17:56
@nikhil nikhil mentioned this pull request Sep 8, 2026
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants