Skip to content

Expand and version-neutralize the tmux start wrapper - #50

Merged
mrfloris merged 2 commits into
masterfrom
codex/1mb-start-neutral-header
Aug 4, 2026
Merged

Expand and version-neutralize the tmux start wrapper#50
mrfloris merged 2 commits into
masterfrom
codex/1mb-start-neutral-header

Conversation

@mrfloris

@mrfloris mrfloris commented Aug 4, 2026

Copy link
Copy Markdown
Member

What changed

  • Make the wrapper header independent of Minecraft, Paper, Java, and architecture versions.
  • Add --version, --doctor, --start [name], --list, and --dry-run [name].
  • Share one safely quoted tmux argument vector between real startup and dry-run.
  • Resolve both tmux and sleep before startup side effects.
  • Expand the fake-tmux package and documentation for the new command contracts.

Why

The wrapper can now diagnose and preview its launch safely, expose its own version, and offer explicit start/list conveniences without taking over Paper lifecycle management. Resolving sleep before session creation also prevents a liveness-probe dependency failure after tmux has already started a session.

User impact

  • Legacy ./1MB-start.sh [name] behavior remains supported.
  • --doctor is read-only and does not query a tmux session or execute the launcher.
  • --dry-run invokes neither tmux, sleep, nor 1MB-minecraft.sh.
  • --list emits one current-user tmux session name per line and preserves tmux's exit status.

Validation

  • Resources/Server/tests/1MB-start/run-tests.sh all
  • Bash 3.2 syntax and behavior passed.
  • Bash 5.3 syntax and behavior passed.
  • ShellCheck passed.
  • 65 passed, 0 failed, 0 skipped.
  • git diff --check passed.
  • Independent focused reviews found no remaining blockers.

@mrfloris
mrfloris merged commit 9ed359d into master Aug 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant