[Xzzz]

Summary

Makes qa/t/2_test_login_totp.t wait for the page to update after each TOTP API call, instead of checking it right away, which made test_selenium_2 fail intermittently.

Enrollment fills in the secret only after user/mfa/totp/enroll returns (js/account.js), and the verification page checks the code with user/mfa/verify_totp_code before it submits the form (js/mfa_totp.js). The test read the secret, the error text and the page title before those calls returned.

Changes

• New wait_until helper in the test, polling once per second up to WAIT_TIME, like 2_test_login_duo.t already does for its title.
• Enrollment waits for the secret before reading it.
• Each Submit on the verification page waits for the error text (invalid code) or for the next page (valid code).

Test plan

• 2_test_login_totp.t passes
• With a 3-second delay added before the API calls in js/account.js and js/mfa_totp.js, it still passes, while the test on master fails at line 91

References

• Bugzilla link: 2090252

[dklawren]

LGTM r=dkl