Skip to content

Bug 2085072 - Remember the Show/Hide External attachments choice across bug pages - #2814

Merged
dklawren merged 2 commits into
mozilla:masterfrom
dklawren:2085072
Nov 6, 2026
Merged

dklawren merged 2 commits into
mozilla:masterfrom
dklawren:2085072

Conversation

@dklawren

@dklawren dklawren commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the change that preserves external-attachment visibility across bug pages.

No open issues 🎉

What changed in this PR

Remembers the Show/Hide External attachments choice across bug pages using Bugzilla.Storage, independently of the remember_collapsed setting.

Changes:

  • Restores the saved external-attachment visibility choice on page load.
  • Saves the choice whenever the toggle is clicked.
  • Updates attachment rows on initialization when the saved choice is “show.”
File Description
extensions/​BugModal/​web/​bug_modal.js Persists and restores external-attachment visibility across bug pages.

Review effort: Balanced

@dklawren
dklawren requested review from Xzzz and cgsheeh November 4, 2026 22:24

@Xzzz Xzzz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@dklawren
dklawren merged commit 9f4e689 into mozilla:master Nov 6, 2026
7 checks passed
@dklawren
dklawren deleted the 2085072 branch November 6, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants