Repository navigation
Bug 2088987 - Bug shouldn't be closed when github commit and backout arrive on the same message - #2813
Merged
Conversation
…arrive on the same message
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the changes preventing revert and backout pushes from incorrectly closing bugs.
No open issues 🎉
What changed in this PR
Prevents GitHub push notifications from incorrectly closing a bug when the push includes a revert or backout for that bug, including pushes that mix fixes and reversions.
Changes:
- Detect revert and backout commit titles and suppress automatic bug closure.
- Explain in the automated comment when a revert or backout prevents closure.
- Add regression tests for revert-only and mixed pushes, plus normal titles containing “revert.”
| File | Description |
|---|---|
qa/t/rest_github_push_comment.t |
Adds helpers and regression tests for comment text and bug status. |
Bugzilla/API/V1/Github.pm |
Tracks revert/backout commits and uses them to guard automatic closure. |
Review effort: Balanced
Xzzz
reviewed
Nov 5, 2026
Xzzz
reviewed
Nov 5, 2026
Xzzz
approved these changes
Nov 5, 2026
Xzzz
left a comment
Xzzz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Approved, with two small inline comments
cgsheeh
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.