Repository navigation
Bug 2089049 - REST /bug/2048343/history fails with internal error: Can't call method "iso8601" on an undefined value at Bugzilla/API/V1/Util.pm line 362 - #2812
Merged
Conversation
…n't call method iso8601 on an undefined value at Bugzilla/API/V1/Util.pm line 362
dklawren
requested review from
Xzzz and
cgsheeh
and
a balanced review from Copilot
November 4, 2026 18:56
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change intended to prevent REST bug-history failures on unparseable date values.
No open issues 🎉
What changed in this PR
Prevents REST bug-history requests from failing when a date value cannot be parsed, such as joined activity values.
Changes:
- Returns unparseable date values as raw strings instead of calling
iso8601()on an undefined value. - Preserves UTC ISO 8601 formatting for valid dates and empty-string handling for missing values.
| File | Description |
|---|---|
Bugzilla/API/V1/Util.pm |
Adds a safe fallback for unparseable dateTime values. |
Review effort: Balanced
Xzzz
approved these changes
Nov 5, 2026
Xzzz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, Thanks!
Just one thing: the description mentions a new t/api-util-type-datetime.t, but it isn't in this PR. Is it wanted?
cgsheeh
approved these changes
Nov 6, 2026
cgsheeh
left a comment
Member
There was a problem hiding this comment.
The PR description mentions a new t/api-util-type-datetime.t test, but it isn't in the diff. Was it left uncommitted? It would be good to include it, ideally with the joined value from bug 2048343.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes (2 files, not committed):