You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Bug 2085141 - Make it more obvious when @mention is going to needinfo someone - #2811
Adds a live aria-live notice under the comment box listing who the comment will needinfo, and who will only be CC'd, visible in both Edit and Preview. Backed by POST /rest/needinfo/mentions, which shares the save-time mention rules, so the notice matches what saving does. Replaces the in-preview mention notice.
… someone
Adds a live aria-live notice under the comment box listing who the comment will needinfo, and who will only be CC'd, visible in both Edit and
Preview. Backed by POST /rest/needinfo/mentions, which shares the save-time mention rules, so the notice matches what saving does. Replaces the in-preview mention notice.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Notification predictions diverge from save behavior for new bugs, non-multiplicable needinfo flags, and restricted flag permissions, promising notifications or requests that will not occur.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The recipient warning can misrepresent saved CC and needinfo outcomes because it ignores pending request changes, product-edit restrictions, and inactive flag types.
… warning
- Treat an inactive needinfo type as CC-only, since core won't add new
flags of an inactive type.
- With strict_isolation on, skip mentioned users who can't edit the
product (add_cc would reject them) in the shared mention filter, so the
warning neither lists them nor gives them a non-multiplicable needinfo
slot.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Programmatically clearing an attachment comment does not emit an input event, leaving a stale needinfo warning visible and pending mention requests valid after switching attachments.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Clear stale needinfo warnings when switching attachments
js/text-editor.js:822
The attachment overlay clears its comment using $form.comment.value = '' in extensions/BugModal/web/attachments_overlay.js:718, without emitting input or resetting the form. After entering a mention and switching attachments, none of these listeners runs, so the discarded comment's needinfo warning remains visible under the empty editor until another change triggers a check. Dispatch a native input event from that programmatic reset path so the warning is cleared and pending mention requests are invalidated.
…leared by script
Setting a textarea's value doesn't fire an input event, so the live
@mention warning stayed visible (and a pending check could still show it)
after the attachment overlay cleared its comment on switching attachments,
and after an instant update cleared the main comment box. Dispatch an
input event in both places, as bug_modal.js already does when it restores
a saved comment.
The reason will be displayed to describe this comment to others. Learn more.
This depends on #2809: once it lands, a new bug's description does needinfo, but this still returns [], so the entry form shows no warning (=> the clone case Connor raised there). Whichever PR merges second should switch this to new_bug_mention_effects. Until then, getMentionParams() could skip the new-bug branch, since the request always returns an empty list.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! One comment above, which depends on #2809.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a live aria-live notice under the comment box listing who the comment will needinfo, and who will only be CC'd, visible in both Edit and Preview. Backed by POST /rest/needinfo/mentions, which shares the save-time mention rules, so the notice matches what saving does. Replaces the in-preview mention notice.