Remote Settings: keep signature verification atomic - #7582
Open
srkyn wants to merge 1 commit into
Open
Conversation
Signed-off-by: David Sarkisyan <david@srkyn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoteSettingsClient::sync()previously released the client lock between inserting fetched records and verifying the collection signature. A concurrent reader could therefore observe the new records before synchronization had finished.This keeps the existing client lock through insertion, signature verification, reset, and retry. The regression test starts a reader while synchronization is in progress and confirms that records are not exposed before the operation completes.
Validation:
cargo test --locked -p remote_settings --features signatures./automation/tests.py changesThe repository automation completed successfully, including tests, clippy, formatting, and the changelog check. This does not change the public API or add dependencies.