FXCM-2281: Integrate EncryptorDecryptor into the autofill database - #7573
Draft
theidkamp wants to merge 1 commit into
Draft
FXCM-2281: Integrate EncryptorDecryptor into the autofill database#7573theidkamp wants to merge 1 commit into
theidkamp wants to merge 1 commit into
Conversation
Move autofill's credit-card encryption onto the shared db-crypto crate and let AutofillDb own the encryptor, as logins' LoginDb does. The consumer supplies it when building the store, so no key is passed into individual calls or down through the sync layers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move autofill's credit-card encryption onto the shared db-crypto crate and let AutofillDb own the encryptor, as logins' LoginDb does. The consumer supplies it when building the store, so no key is passed into individual calls or down through the sync layers.
Blocked on #7542 this branch does not build until the shared crate lands,
so CI here will be red. Verified locally against #7542's current head
(
cc7212f7d):cargo fmt --checkclean,cargo clippy --all-targetsclean,91 tests passing.
Open Questions
Pull Request checklist
[ci full]to the PR title.