Repository navigation
Move to the Mojo 1.3 nightly (1.3.0.dev2026111805) - #550
Draft
winding-lines wants to merge 4 commits into
Draft
winding-lines wants to merge 4 commits into
winding-lines wants to merge 4 commits into
Conversation
- pixi.toml: mojo-compiler and mojo pinned ==1.3.0.dev2026111805 in the workspace, the package's host, build and run dependencies, and the data and fmt features (fmt takes `mojo`, which ships `mojo format`). The stable feature's tins move into [dependencies] and its DEP_INC into [activation.env]; the nightly feature (sources and flare's shims built from checkouts) and the stable and nightly environments are gone. - Every tin re-pinned to its port: dista 628025d, k8s, iceberg, postgres, objectstore (+shim), arrow-mlake, memory-region, threads, flare_mlake, json_mlake, sqlite, zstd, lz4, brotli, mozz_mlake; the same revision in pixi.toml, CI's checkouts and deploy/Dockerfile's DISTA_REV/K8S_REV. - The ouromo feature and environment are commented out: the only ouromo published (1.2.0.1) depends on mojo-compiler ==1.2.0, which can't be installed beside the new pin. - deploy/runtime/pixi.toml, tests/example-project.sh and tests/runtime-image.sh pin the same compiler; deploy/runtime/pixi.lock and pixi.lock written again. - String.find()/rfind() return Optional[Int]: every call takes .or_else(-1), which keeps each site's logic, two presence tests become `in`/`not in`; also in the Mojo that scripts/unit-tests.sh and scripts/pipelines.sh generate. - StringSlice -> StringSpan; Ordering.RELEASE/ACQUIRE -> release/acquire. - morca_main and the other functions over `P: type_of(Pipeline)` call P's static methods through PipelineOf[P] (morca.pipeline), the same Pipeline named by P's parameters: this nightly can't infer a struct's parameters for a static method called on such a P. - New warnings fixed: dead initial stores become deferred declarations, an unused Dict removed (views/steps.mojo), a `^` on a borrowed argument removed (api/actions.mojo). - CI: no env matrix or nightly-only checkouts; release-check gets mojo-compiler; README and DESIGN.md name the new Mojo. - changes/: a minor fragment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017TycsxF3PkSX49fnv7cSZd
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017TycsxF3PkSX49fnv7cSZd
…cache Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017TycsxF3PkSX49fnv7cSZd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of moving every magmalake tin, and morca with them, from stable Mojo 1.2.0 to one pinned Mojo 1.3 nightly,
1.3.0.dev2026111805.pixi.toml: one toolchain.mojo-compiler(andmojo, formojo formatand the llvm-symbolizer the image ships) pinned exactly in the workspace, the package's host, build and run dependencies, and thedataandfmtfeatures. Thestablefeature's tins move into[dependencies]; thenightlyfeature (dependencies and flare's shims built from checkouts) and thestable/nightlyenvironments are gone.pixi.toml, CI's checkouts anddeploy/Dockerfile: dista628025d(morca-dev/distamojo-1.3-nightly), k8s, iceberg, postgres, objectstore (+shim), arrow-mlake, memory-region, threads, flare_mlake, json_mlake, sqlite, parquet, thrift, hashes, snappy, deflate, avro, roaring, zstd, lz4, brotli, mozz_mlake.deploy/runtime/pixi.toml,tests/example-project.shandtests/runtime-image.shpin the same compiler; both locks written again.mojo-compiler ==1.2.0, which can't be installed beside the new pin, so its feature and environment are commented out (with why) until an ouromo on this Mojo exists. Owner's call.String.find()/rfind()returnOptional[Int]: every call takes.or_else(-1), which keeps each site's logic exactly (no site compared a result with== -1/!= -1or tested it for truth); two presence tests becamein/not in. The same in the Mojo thatscripts/unit-tests.shandscripts/pipelines.shgenerate.morca_mainand the other functions overP: type_of(Pipeline): this nightly can't infer a struct's parameters for a static method called on such aP("failed to infer parameter 'name' of parent struct 'Pipeline'"), though it readsP's parameters fine. They call throughPipelineOf[P](morca.pipeline), the samePipelinenamed byP's parameters. No change for callers.StringSlice→StringSpan,Ordering.RELEASE/ACQUIRE→release/acquire, and the nightly's new warnings (dead initial stores, a deadtry,^on borrowed or already-owned values, doc-string capitals).release-checkgetsmojo-compiler.changes/: a minor fragment.Verified locally (osx-arm64): all 87 tasks of
test(test-executor-core, -workers, test-scheduler-ui) pass;test-priorityonly under bash, since macOS's /bin/sh keeps a variable assigned before a function call (unrelated to the port). The data environment's test-data-tables/sensors/keyed andtaxipass, but only against a liblake built with--no-optimization(below).fuzz(20,000 runs each),format-check,check_layers.py, no-orca, sql-in-db, file-size, version,lock.sh --checkpass. No warnings from morca's own sources.Not working, needs a decision:
mojo build --emit shared-libofsrc/morca/_lake/liblake.mojofails with an undefinedparquet::assemble::build_field(...)referenced fromParquetReader._assemble(a function referenced but never emitted), the shape seen with iceberg'scarrow-scan-lib. It links with--no-optimization. Sobuild-liblakeandpixi buildof morca-mojo fail on osx-arm64; Linux is up to CI. A compiler bug; nothing here works around it.rustenvironment's Mojo segfaults on macOS (evenmojo --version): this nightly's mojo-compiler shipslib/libLLVM.dylib(1.2.0 didn't), and conda-forge'srustships one at the same path, which replaces it. The Mojo sources of the Rust tests compile in the data environment; the Rust tests themselves didn't run here.Not run here: kind, the runtime/project images (Docker), project-test/release, the Lean
formaljob, customs, the Linux-only paths of test-cgroups/test-usage/test-pressure/test-sample (they skip on macOS).Not to be released on its own: the tins release together as one wave.
🤖 Generated with Claude Code
https://claude.ai/code/session_017TycsxF3PkSX49fnv7cSZd