Repository navigation
Pipeline fire= replaces fills=; describe says schedule.fire (#370) - #535
Merged
Merged
Conversation
`Pipeline[..., fire=Previous]` picks the partition a scheduled fire runs. `fills=` stays accepted for one release (setting both doesn't compile), and describe writes `schedule.fills` beside `schedule.fire` with the same value, so older schedulers still read it. The scheduler and the UI read `fire`, falling back to `fills`. The Rust SDK gets `fire_current()` and emits both keys. Registry hashes are unchanged: the schedule isn't hashed. morca.toml's `fills` (the automatic backfill) keeps its name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017TycszSbyw92Efu4ZeCYL6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017TycszSbyw92Efu4ZeCYL6
winding-lines
force-pushed
the
fire-370
branch
from
November 17, 2026 08:28
babf09d to
0b49bc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #370.
fire=onPipeline.Pipeline[..., fire=Previous]picks the partition a scheduled fire runs.fills=stays accepted for one release and gives the same schedule; setting both doesn't compile (tests/compile_fail/fire_and_fills.mojo).tests/test_cron.mojotest_fills_is_firechecks that afills=pipeline and afire=one have the same describe, hash and partition for every fire. Mojo has no clean compile-time warning for a parameter:@deprecatedon a helper called in acomptime ifwarns on every build, whichever branch is taken, so the deprecation is in the docstrings and the changelog instead.schedulehasfireand, for one release,fillswith the same value, so older schedulers still read it. The scheduler (db/registered.mojo) and the pipelines view readfire, falling back tofills. The pipelines API'sschedulegetsfiretoo. docs/pipeline-protocol.md says so; itspipeline.mojo:Nline references are moved to the new lines.Cron::fire_current();fills_current()stays,#[deprecated]. describe emits both keys.describe.hash, with the manifests' pins).fills(the automatic backfill), which keeps its name. Tests and DESIGN.md usefire=.Not here: the morca.dev site (
src/pages/docs/build.astro, the generated API json) still saysfills=. That's a separate repo.Partitions.fillandPipeline.fills_forkeep their names because they are public API.Local runs (
-e ouromounless noted): test-cron, test-steps, test-compile-fail, the keyed compile-fail files (-e data), test-conformance, test-hourly, test-weekly, test-ui,-e rust test-rust-sdk, format-check.🤖 Generated with Claude Code
https://claude.ai/code/session_017TycszSbyw92Efu4ZeCYL6