Skip to content

Pipeline fire= replaces fills=; describe says schedule.fire (#370) - #535

Merged
winding-lines merged 2 commits into
mainfrom
fire-370
Nov 17, 2026
Merged

winding-lines merged 2 commits into
mainfrom
fire-370

Conversation

@winding-lines

Copy link
Copy Markdown
Contributor

Closes #370.

  • fire= on Pipeline. Pipeline[..., fire=Previous] picks the partition a scheduled fire runs. fills= stays accepted for one release and gives the same schedule; setting both doesn't compile (tests/compile_fail/fire_and_fills.mojo). tests/test_cron.mojo test_fills_is_fire checks that a fills= pipeline and a fire= one have the same describe, hash and partition for every fire. Mojo has no clean compile-time warning for a parameter: @deprecated on a helper called in a comptime if warns on every build, whichever branch is taken, so the deprecation is in the docstrings and the changelog instead.
  • describe. schedule has fire and, for one release, fills with the same value, so older schedulers still read it. The scheduler (db/registered.mojo) and the pipelines view read fire, falling back to fills. The pipelines API's schedule gets fire too. docs/pipeline-protocol.md says so; its pipeline.mojo:N line references are moved to the new lines.
  • Rust SDK. Cron::fire_current(); fills_current() stays, #[deprecated]. describe emits both keys.
  • Registry hashes unchanged, since the schedule isn't hashed: toy 0xa3bcc571ad7c6939, daily 0x81ead348d0a21c1f, fanout 0x1f0ebf1f2a93d993 (the conformance suite's describe.hash, with the manifests' pins).
  • Wording. The UI, docs and docstrings say "fire" for the scheduled partition ("each fire runs the previous partition"); "fill" is only for morca.toml's fills (the automatic backfill), which keeps its name. Tests and DESIGN.md use fire=.

Not here: the morca.dev site (src/pages/docs/build.astro, the generated API json) still says fills=. That's a separate repo. Partitions.fill and Pipeline.fills_for keep their names because they are public API.

Local runs (-e ouromo unless noted): test-cron, test-steps, test-compile-fail, the keyed compile-fail files (-e data), test-conformance, test-hourly, test-weekly, test-ui, -e rust test-rust-sdk, format-check.

🤖 Generated with Claude Code

https://claude.ai/code/session_017TycszSbyw92Efu4ZeCYL6

winding-lines and others added 2 commits November 17, 2026 00:26
`Pipeline[..., fire=Previous]` picks the partition a scheduled fire runs.
`fills=` stays accepted for one release (setting both doesn't compile),
and describe writes `schedule.fills` beside `schedule.fire` with the same
value, so older schedulers still read it. The scheduler and the UI read
`fire`, falling back to `fills`. The Rust SDK gets `fire_current()` and
emits both keys. Registry hashes are unchanged: the schedule isn't hashed.
morca.toml's `fills` (the automatic backfill) keeps its name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017TycszSbyw92Efu4ZeCYL6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017TycszSbyw92Efu4ZeCYL6
@winding-lines
winding-lines merged commit afa3ac9 into main Nov 17, 2026
35 checks passed
@winding-lines
winding-lines deleted the fire-370 branch November 17, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fills means two unrelated things in code and in orca.toml

1 participant