fix(vue): удаление из грида настроек без двойного confirm - #631
Merged
Conversation
Row delete handlers no longer call confirm.require after ActionsColumn already confirmed via API grid config (confirm: true). Shared gridDeleteAction helper aligns deliveries, payments, statuses, vendors, and links with CustomersGrid pattern. Closes #630
AgelxNash
pushed a commit
to AgelxNash/MiniShop3
that referenced
this pull request
Sep 6, 2026
16 tasks
AgelxNash
pushed a commit
to AgelxNash/MiniShop3
that referenced
this pull request
Sep 6, 2026
Conflict resolution: PR 640 supersedes merged modx-pro#621 rework (same author, same intent) — took PR side for 36 files; manually preserved modx-pro#631 useConfirm grids, modx-pro#623 datefield dialog styles, modx-pro#643 gallery bits, modx-pro#605 order entry; ProductData sections rebuilt on groupProductDataSections (keeps modx-pro#611/modx-pro#620 sort_order) under PR 640 Panel layout.
|
Этот PR включён в тестовую интеграционную сборку всех открытых PR MiniShop3: AgelxNash/MiniShop3, ветка Сборка нужна, чтобы проверить совместимость взаимозависимых серий PR до их мержа — при последовательном слиянии они конфликтуют друг с другом. Это не ревью и не конкурирующий PR: авторство сохранено (1 PR = 1 коммит с исходным автором), ветка пересобирается по мере обновления PR. Как вошёл в сборку: Слился чисто. (useConfirm-механика из этого PR сохранена в гридах при последующем #640.) |
16 tasks
|
Привет! Просто пожелание: удачи с этим PR 🚀 Работа нужная — пусть рассмотрят и смержат как можно скорее. Успехов! |
Ibochkarev
added a commit
that referenced
this pull request
Sep 8, 2026
Keep barrel PrimeVue imports from the theme PR and drop unused useConfirm — delete flows already use gridDeleteAction from #631.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Удаление строки через колонку «Действия» в гридах Настроек (доставки, оплаты, статусы, производители, связи) не работало: конфиг из БД задаёт
confirm: trueдля delete,useActionsпоказывал первый диалог, а handler (deleteDeliveryи др.) открывал второйconfirm.require()— DELETE не выполнялся.Правка выравнивает паттерн с
CustomersGrid/OrdersGrid: один confirm вActionsColumn/useActions, handler только выполняет DELETE.Closes #630
Тип изменений
Связанные Issues
Closes #630
Как это было протестировано?
Конфигурация: ветка
fix/issue-630-grid-delete-confirm, Node 18+Чеклист
npm run lint:ci)Дополнительные заметки
vueManager/src/utils/gridDeleteAction.js(gridDeleteAction,applyDeleteConfirmDefaults).DeliveriesGrid,PaymentsGrid,StatusesGrid,VendorsGrid,LinksGrid.useSelectionбез изменений.