Fix(_remap_obs): fix support for GWF observation types with 2 cellids - #2842
Open
jlarsen-usgs wants to merge 6 commits into
Open
Fix(_remap_obs): fix support for GWF observation types with 2 cellids#2842jlarsen-usgs wants to merge 6 commits into
jlarsen-usgs wants to merge 6 commits into
Conversation
* single reach models crashed due to np.diff(reach_data).max() > 0 comparison, fix for this issue breaks up this comparison by taking the diff first and evaluating if the diff returns an empty result prior to taking the max()
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2842 +/- ##
===========================================
+ Coverage 55.5% 73.6% +18.1%
===========================================
Files 644 659 +15
Lines 124135 132278 +8143
===========================================
+ Hits 68947 97477 +28530
+ Misses 55188 34801 -20387
🚀 New features to boost your workflow:
|
jlarsen-usgs
marked this pull request as ready for review
September 4, 2026 23:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.