Skip to content

fix(ModflowSfr2): support single reach models - #2841

Merged
jlarsen-usgs merged 3 commits into
modflowpy:developfrom
jdlarsen-UA:develop
Sep 4, 2026
Merged

fix(ModflowSfr2): support single reach models#2841
jlarsen-usgs merged 3 commits into
modflowpy:developfrom
jdlarsen-UA:develop

Conversation

@jlarsen-usgs

Copy link
Copy Markdown
Contributor
  • single reach models crashed due to np.diff(reach_data).max() > 0 comparison, fix for this issue breaks up this comparison by taking the diff first and evaluating if the diff returns an empty result prior to taking the max()

* single reach models crashed due to np.diff(reach_data).max() > 0 comparison,
fix for this issue breaks up this comparison by taking the diff first and
evaluating if the diff returns an empty result prior to taking the max()
@jlarsen-usgs

Copy link
Copy Markdown
Contributor Author

Testing to be added shortly

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.6%. Comparing base (556c088) to head (cce415a).
⚠️ Report is 226 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/modflow/mfsfr2.py 82.3% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2841      +/-   ##
===========================================
+ Coverage     55.5%    73.6%   +18.0%     
===========================================
  Files          644      659      +15     
  Lines       124135   132282    +8147     
===========================================
+ Hits         68947    97402   +28455     
+ Misses       55188    34880   -20308     
Files with missing lines Coverage Δ
flopy/modflow/mfsfr2.py 85.5% <82.3%> (-1.8%) ⬇️

... and 585 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlarsen-usgs
jlarsen-usgs marked this pull request as ready for review September 4, 2026 19:04
@jlarsen-usgs
jlarsen-usgs merged commit fe12416 into modflowpy:develop Sep 4, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant