Add contents hierarchy to collection display (ARC-149) - #67
Draft
ssciolla wants to merge 14 commits into
Draft
Conversation
…use blended; tidy up a couple things
rshiggin
reviewed
Aug 10, 2026
Member
There was a problem hiding this comment.
What changed and why
- jQuery removed entirely
- turbolinks:load → turbo:load. Turbolinks is gone in Rails 8.
- navigation.contains.elements → turbo:frame-load. In ArcLight 1.x, contents pagination arrives via turbo-frames, so turbo:frame-load is the correct replacement.
- Event delegation replaces per-element binding. The new model: one listener on document, forever, when you click a checkbox, the change event fires on the checkbox, then bubbles up through every ancestor: label → div → body → document. A listener anywhere on that path hears it.
- Event delegation instead of per-element binding. One change listener on document replaces BindEvents()/SelectCheckbox binding to each checkbox and the data-initialized guard. New checkboxes work automatically.
- CSS.escape() used when building the value selector in restoreCheckboxes, preventing breakage/injection from special characters in identifiers.
- harvestItemMetadata uses a dirty flag to save state only once (old buildCollectionItemsMap called saveCollectionItems() inside the loop on every item).
- Removed sessionSave utility and its null-removal branch; saving is now inline in saveState.
- Constants CHECKBOX_SELECTOR and FORM_ID replace repeated string literals.
Net effect: same behavior and storage format, but dependency-free, Turbo-compatible, more robust to dynamically loaded content, and safer/cleaner.
… in contents hierarchy; add container_types to component EAD config; add needed methods to SolrDocument
…her event listener method
ssciolla
force-pushed
the
arc-149-contents
branch
from
August 11, 2026 21:03
34f8449 to
e36a141
Compare
…tmap and applications.js, not via manifest.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To Do
umich, especiallyaeonform.jshttps://mlit.atlassian.net/browse/ARC-161