Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/codeql/codeql-config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: MemoryEcho CodeQL config

# Excluded from analysis. Only applies to languages analyzed without a build
# (javascript-typescript, actions) — the Swift job builds, so it ignores this.
paths-ignore:
# Self-extracting bundles, generated from the *.dc.html sources next to
# them. Each inlines its whole payload as base64 in a <script> tag and
# unpacks it at load time, so there is no hand-written code in here to
# review: the sources, support.js and ios-frame.jsx are the real thing and
# stay in scope.
#
# The loader trips js/xss-through-dom at its DOMParser call, reading the
# template out of a <script type="__bundler/template"> block in the same
# file. CodeQL counts that as untrusted DOM text; it's a string literal the
# bundler wrote, and nothing on the path reaches the network, the URL or
# postMessage.
#
# Listed by name rather than as mocks/*.html: `*` matches dots, so the glob
# would take the .dc.html sources with it, and paths-ignore has no way to
# add them back (`!` is matched literally, not as a negation). A new bundle
# needs a new line here.
- 'mocks/MemoryEcho.html'
- 'mocks/MemoryEcho Add.html'
7 changes: 6 additions & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ jobs:
- language: actions
build-mode: none
# The design mocks under mocks/. They don't ship in the app, but
# they're public code in the repo all the same.
# they're public code in the repo all the same. The generated
# bundles are excluded; see the config file.
- language: javascript-typescript
build-mode: none

Expand All @@ -107,6 +108,10 @@ jobs:
with:
languages: ${{ matrix.language }}
build-mode: ${{ matrix.build-mode }}
# paths-ignore for the generated mock bundles. It's shared by both
# languages in the matrix rather than set per-entry: the paths it
# names hold no workflow files, so it's a no-op for actions.
config-file: .github/codeql/codeql-config.yml

- name: Perform CodeQL analysis
uses: github/codeql-action/analyze@2892aa5e19bbd11bc0cff5427e3b750a04d9e3c2 # v4
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/dependabot-automerge.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
name: Dependabot auto-merge

# Turns on GitHub's native auto-merge for Dependabot PRs. This workflow doesn't
# merge anything itself: GitHub does, and only once branch protection is
# satisfied — the required checks (lint + unit tests) are green and the branch
# is up to date with main. A red PR just sits open like it always did.
# merge anything itself: GitHub does, and only once the `main` ruleset is
# satisfied — the required checks (lint, unit tests, and the two CodeQL jobs
# that run on PRs) are green. A red PR just sits open like it always did.
#
# The ruleset deliberately does not require the branch to be up to date with
# main: with that on, two Dependabot PRs open at once leave the second one
# stranded behind the first until Dependabot's next weekly run.
#
# A merge made on behalf of GITHUB_TOKEN does not fire `push` workflows, so the
# UI tests and the Swift CodeQL job do not run on main after these merges.
# CodeQL's weekly schedule covers main.
on: pull_request

permissions: {}
Expand Down
Loading