ci: move workflows to the node24 action majors - #43
Open
mike-diff wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears both annotations that every CI run has been emitting, neither of which
was a real decision.
1. Node 20 deprecation (a scheduled hard failure)
GitHub is force-running node20 actions on node24 today and will drop that shim.
Verified runtimes per major:
actions/checkoutactions/setup-goBumped to the minimal majors that reach node24 rather than latest (v7/v7).
checkout@v5was already running indispatch.yml, so this also makes thethree workflows consistent instead of leaving
ci.ymlandrelease.ymla majorbehind their sibling. Two proven small steps beat one unproven large one.
The open question going in was whether
setup-go@v6still accepts a literalgo-version: "1.22"or wantsgo-version-file. It accepts it, confirmed by areal run, so the version declaration is untouched.
2. Module cache that can never hit
setup-gokeys the module cache ongo.sum. sesh has nogo.sum, because ithas no dependencies. So all three workflows attempted and failed a cache restore
on every run, and
dispatch.ymlwas explicitly opted in withcache: true.Set
cache: falseeverywhere. This is not warning suppression: it makes theconfig state what the project actually is. It also drops a pointless network
round trip per job.
The reason it is worth fixing at all is attention. Two permanent warnings on
every green run teach you to skim annotations, which is exactly how a real one
gets missed later.
Verification
CI green on this branch with zero annotations:
All three workflow files were parsed and their resolved action versions and
cache values asserted before pushing. A malformed workflow degrades to "no runs
at all", which is the one failure mode that looks like success.
Scope
.github/workflows/only. No Go code touched.Overlaps
ci.ymlwith #44 (which edits theteststep'srun:whilethis edits the
uses:lines and addscache:). Different lines, so it mergescleanly, but the merged result is worth one glance to confirm both survived.
Recommend taking this one first: smaller, entirely config, and it removes the
scheduled failure before a feature diff is reviewed against it.