Fix localization string import - #14743
Draft
Sean McManus (sean-mcmanus) wants to merge 1 commit into
Draft
Conversation
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
September 5, 2026 05:28
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved approval-blocking issues were identified.
Pull request overview
Fixes EDGE localization imports so unrelated directories no longer stop processing, while refreshing one diagnostic across 13 locales.
Changes:
- Skip unsupported localization directories.
- Update localized IntelliSense diagnostic translations.
File summaries
| File | Description |
|---|---|
Extension/bin/messages/zh-tw/messages.json |
Updates Traditional Chinese translation. |
Extension/bin/messages/zh-cn/messages.json |
Updates Simplified Chinese translation. |
Extension/bin/messages/tr/messages.json |
Updates Turkish translation. |
Extension/bin/messages/ru/messages.json |
Updates Russian translation. |
Extension/bin/messages/pt-br/messages.json |
Updates Brazilian Portuguese translation. |
Extension/bin/messages/pl/messages.json |
Updates Polish translation. |
Extension/bin/messages/ko/messages.json |
Updates Korean translation. |
Extension/bin/messages/ja/messages.json |
Updates Japanese translation. |
Extension/bin/messages/it/messages.json |
Updates Italian translation. |
Extension/bin/messages/fr/messages.json |
Updates French translation. |
Extension/bin/messages/es/messages.json |
Updates Spanish translation. |
Extension/bin/messages/de/messages.json |
Updates German translation. |
Extension/bin/messages/cs/messages.json |
Updates Czech translation. |
Extension/.scripts/import_edge_strings.ts |
Continues past unsupported directories. |
Review details
- Files reviewed: 1/14 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip unrelated source directories during EDGE string import and refresh the translated diagnostic for excessive nested user-defined conversions in 13 locales.
User impact
[Minor] A localization refresh can silently stop before processing supported locales when the source checkout contains an unrelated directory. A later extension release can consequently retain stale or missing localized IntelliSense diagnostics until the import is rerun from a different checkout layout.
Root cause
The importer added in #11262 returned from the entire operation when it encountered the first directory outside its fixed locale table. A standalone Git checkout exposes
.gitas a directory, so the command could exit successfully before importing any locale.Fix
Continue past unrecognized directories instead of ending the import. The generated update adds the newly available translations while preserving the reviewed corrections from #14676.