Skip to content

Fix custom configuration provider regression - #14725

Merged
Sean McManus (sean-mcmanus) merged 6 commits into
mainfrom
seanmcm/devbox2-wsl/agent32/fix-custom-configuration-providers
Sep 3, 2026
Merged

Fix custom configuration provider regression#14725
Sean McManus (sean-mcmanus) merged 6 commits into
mainfrom
seanmcm/devbox2-wsl/agent32/fix-custom-configuration-providers

Conversation

@sean-mcmanus

@sean-mcmanus Sean McManus (sean-mcmanus) commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Restore canProvideConfiguration calls for each requested URI before invoking the batched provideConfigurations request. This preserves provider initialization and filtering behavior while retaining the multi-file batching introduced in #14582.

Add integration coverage for a provider that prepares its file configuration during canProvideConfiguration, and run the containing SimpleCppProject scenario in CI on Windows, Linux, and macOS.

Fixes #14724.

This PR was investigated and created by Copilot with GPT-5.6 Sol (in VS Code). Any message starting with ✨Copilot: was sent by Copilot.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The implementation restores prior provider behavior and includes targeted regression coverage.

Pull request overview

Restores per-URI provider initialization and filtering while retaining batched configuration requests.

Changes:

  • Calls canProvideConfiguration before batching supported URIs.
  • Adds integration coverage for provider initialization ordering.
File summaries
File Description
Extension/src/LanguageServer/client.ts Filters and initializes URIs before requesting configurations.
Extension/test/scenarios/SimpleCppProject/tests/languageServer.integration.test.ts Verifies initialization precedes configuration provisioning.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨Copilot (agent50): Reviewed source e7240568 merged over main at 2f25880c (provider merge 79b663e2; parents confirmed).

Root cause verified rather than assumed: #14582 removed the canProvideConfiguration call, and the provider named in #14724 populates its foundFiles cache as a side effect of that call, so its provideConfigurations returned an empty array and IntelliSense fell back to the host compiler with no provider include paths. Restoring the call before the batched request fixes that, and the restored semantics match the pre-#14582 code exactly — including the subtle case where a thrown canProvideConfiguration still leaves the URI treated as supported. Filtering to supportedUris is safe for partial batches, since sendCustomConfigurations is keyed per URI.

Two non-blocking comments below. I could not run the SimpleCppProject scenario locally (extension dependencies and native test binaries are not deployed in this worktree), so the test change is reviewed statically; current-head CI covers compile, lint, and unit tests only.

Comment thread Extension/src/LanguageServer/client.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The implementation restores the previous provider contract with focused cross-platform regression coverage.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@bobbrow Bob Brown (bobbrow) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional comment

Comment thread Extension/src/LanguageServer/client.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The implementation restores the expected provider lifecycle and includes appropriate cross-platform regression coverage.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨Copilot (agent50): Re-reviewed at 3e8d1092 (merge 71576369 over main 2857a071; parents confirmed). The delta since 75a3078c is whitespace-only — git diff -w between the two revisions is empty — so there is no behavioral change to re-validate.

Current-head CI is fully green on all three platforms, and I confirmed the individual steps rather than the job conclusions: Compile Sources, Run Linter, Run unit tests, and Run SimpleCppProject tests all succeeded on windows-2025, ubuntu-24.04, and macos-15. That is stronger evidence than my earlier single-platform local runs, and it means the regression guard added here now demonstrably runs and passes everywhere.

One non-blocking nit below about the scope of the new hunk. The fix itself remains correct and, from my side, ready to merge.

Comment thread Extension/src/LanguageServer/client.ts
@sean-mcmanus
Sean McManus (sean-mcmanus) merged commit 0376beb into main Sep 3, 2026
6 checks passed
@sean-mcmanus
Sean McManus (sean-mcmanus) deleted the seanmcm/devbox2-wsl/agent32/fix-custom-configuration-providers branch September 3, 2026 16:49
@github-project-automation github-project-automation Bot moved this from Pull Request to Done in cpptools Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1.33.5 broke custom configuration providers

3 participants