Repository navigation
[rush] Update Azure Identity to require patched MSAL Node - #6191
Open
Sean Larkin (TheLarkInn) wants to merge 1 commit into
Open
Sean Larkin (TheLarkInn) wants to merge 1 commit into
Sean Larkin (TheLarkInn) wants to merge 1 commit into
Conversation
Bump the Azure build-cache plugin to @azure/identity ~4.14.1 and refresh its resolved dependency closure. Add regression coverage for both the declared MSAL minimum and the package actually resolved from Azure Identity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2eb6787c-aea0-4321-a711-75c899f2b233
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the Azure storage build-cache plugin to
@azure/identity ~4.14.1, which requires@azure/msal-node ^7.1.0. The existing~4.13.1range cannot select this update and currently resolves MSAL Node 6.0.1 in a fresh published Rush installation.Details
Reproduced using only public npm packages:
The resulting lockfile contains this dependency chain:
This changes the published dependency range, not just the monorepo's lockfile or an application-level override. The updated plugin resolves Azure Identity 4.14.1 and MSAL Node 7.1.2. Unrelated lockfile entries are unchanged; the older Azure Identity used by other development tools is retained.
Added two offline regression checks: Azure Identity's declared MSAL minimum must be at least 7.1.0, and the MSAL package actually resolved from Azure Identity must meet that minimum. Test-only semver dependencies are declared explicitly.
Compatibility: Azure Identity 4.14.1 requires Node.js 22 or newer, as does 4.13.3 currently selected by the previous range in fresh installs. Validation used the repository-supported Node.js 22.23.4. No authentication-flow or public API code is changed.
How it was tested
rush build --to @rushstack/rush-azure-storage-build-cache-pluginpasses, including the dependency closure, type-checking, lint, and API extraction.rush test --only @rushstack/rush-azure-storage-build-cache-pluginpasses all 35 tests.rush install --subspace default --max-install-attempts 1accepts the final lockfile and generated repository state.rush change --verify --no-fetch --target-branch origin/mainpasses.rush-pnpm packand installed it alongside public@microsoft/rush-lib@5.182.1in a separate clean fixture. npm deduplicates Rush's plugin dependency to the packed plugin and resolves@azure/identity@4.14.1 -> @azure/msal-node@7.1.2.Includes a Rush patch change file.