Repository navigation
Fix GCC 14 build failure in graph topological sort - #34068
Open
Tianlei Wu (tianleiwu) with Copilot wants to merge 5 commits into
Open
Tianlei Wu (tianleiwu) with Copilot wants to merge 5 commits into
Tianlei Wu (tianleiwu) with Copilot wants to merge 5 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Signed-off-by: Christian Bourjau <christian.bourjau@quantco.com> Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
The ready set was kept in a sorted std::list. Inserting with std::upper_bound walks the list linearly, so each push cost O(n) in the queue length. Graphs with many simultaneously ready nodes (e.g., many Constant nodes without inputs) made every topological sort quadratic. GraphViewer runs this sort on construction, and most graph transformers construct a GraphViewer, so session creation was dominated by it. Replace the list with a std::priority_queue. The visit order is unchanged: both structures pop the greatest node under `comp`, and PriorityNodeCompare (the only caller's comparator) is a strict total order because it breaks ties by node index. Signed-off-by: Christian Bourjau <christian.bourjau@quantco.com> Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
ReplaceInputsToUseSharedInitializer copied the shared initializer's consumer list and searched it linearly before adding each consumer. That list grows with every replaced duplicate, making the transformer quadratic in the number of duplicate initializers. Graph::AddConsumerNode inserts into a set and already ignores duplicates, so call it unconditionally. Signed-off-by: Christian Bourjau <christian.bourjau@quantco.com> Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for Build Linux x64 MinSizeRel
Fix GCC 14 build failure in graph topological sort
Nov 10, 2026
Tianlei Wu (tianleiwu)
marked this pull request as ready for review
November 10, 2026 04:42
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the GCC 14 build fix and related session-creation optimizations.
No open issues 🎉
What changed in this PR
Addresses the GCC 14 build failure in graph topological sorting while retaining the session-creation optimizations from PR #33939.
Changes:
- Uses a
std::vector-backed priority queue to avoid theInlinedVectormove warning while preserving heap-based traversal and ordering. - Removes redundant consumer lookups during constant sharing.
- Retrieves tensor element types directly from node type metadata in the allocation planner.
| File | Description |
|---|---|
onnxruntime/core/optimizer/constant_sharing.cc |
Relies on consumer-set deduplication instead of copying and searching consumers. |
onnxruntime/core/graph/graph.cc |
Uses a vector-backed binary heap for efficient topological traversal. |
onnxruntime/core/framework/allocation_planner.cc |
Avoids indirect type conversion when retrieving tensor element types. |
Review effort: Balanced
Rui Ren (rui-ren)
approved these changes
Nov 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
std::vectoras the priority queue’s backing container inKahnsTopologicalSort, avoiding the GCC 14-Werror=uninitializedwarning triggered by moving anInlinedVector.Motivation and Context
The Linux MinSizeRel build with exceptions disabled failed while compiling
graph.cc: GCC 14 treated an AbseilInlinedVectormove-constructor warning as an error. This change avoids that move while preserving the priority queue’s ordering.