Repository navigation
Record completed_at for ContinuedAsNew executions - #32
Draft
Thom Chiovoloni (thomcc-work) wants to merge 1 commit into
Draft
Thom Chiovoloni (thomcc-work) wants to merge 1 commit into
Thom Chiovoloni (thomcc-work) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Thom Chiovoloni (thomcc-work)
October 6, 2026 18:36
View session
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The production data backfill and replacement of a critical acknowledgement function warrant the planned manual testing and human review.
Review effort: Balanced
Findings: None
What changed in this PR
Records completion timestamps for continued-as-new executions, enabling age-based pruning of older generations.
Changes:
- Updates acknowledgement logic and backfills recoverable timestamps.
- Adds regression coverage for migration and pruning behavior.
- Documents migration behavior and operational guidance.
| File | Description |
|---|---|
migrations/0024_continue_as_new_completed_at.sql |
Updates and backfills completion timestamps. |
migrations/0024_diff.md |
Documents the migration delta. |
migrations/README.md |
Adds upgrade and pruning guidance. |
src/migrations.rs |
Refreshes the migration embedding marker. |
tests/regression_tests.rs |
Tests fresh installs, upgrades, and pruning. |
CHANGELOG.md |
Records the fix under Unreleased. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like an oversight that this was missed, but maybe I'm mistaken. This is required for us to properly clean up executions in old (but still-running) workflows.
This PR is still WIP, not thoroughly tested or manually reviewed in depth yet.