Skip to content

Fill the config cycle into the TS18000 circularity message #65091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ryan Cavanaugh (RyanCavanaugh) merged 1 commit into from
Nov 2, 2026
+35 −1
Merged

Fill the config cycle into the TS18000 circularity message #65091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tsc/internal/tsoptions/tsconfigparsing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,7 @@ func parseConfig(
var errors []*ast.Diagnostic
if slices.Contains(resolutionStack, resolvedPath) {
var result *parsedTsconfig
errors = append(errors, ast.NewCompilerDiagnostic(diagnostics.Circularity_detected_while_resolving_configuration_Colon_0))
errors = append(errors, ast.NewCompilerDiagnostic(diagnostics.Circularity_detected_while_resolving_configuration_Colon_0, strings.Join(append(core.Map(resolutionStack[slices.Index(resolutionStack, resolvedPath):], tspath.PathKey.AsString), resolvedPath.AsString()), " -> ")))
if json.Size() == 0 {
result = &parsedTsconfig{raw: json}
} else {
Expand Down
34 changes: 34 additions & 0 deletions tsc/internal/tsoptions/tsconfigparsing_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,6 +1067,40 @@ func TestParseJsonSourceFileConfigFileContentReportsInvalidExtendedConfig(t *tes
}
}

func TestParseJsonSourceFileConfigFileContentReportsCircularExtendsChain(t *testing.T) {
t.Parallel()
files := map[string]string{
"/project/tsconfig.json": `{ "extends": "./a.json" }`,
"/project/a.json": `{ "extends": "./b.json" }`,
"/project/b.json": `{ "extends": "./a.json" }`,
"/project/main.ts": "export const x = 1;",
}
fs := tsoptionstest.NewVFS(files, tspath.CaseSensitive /*caseSensitivity*/)
configFileName := tspath.RootedFilePath("/project/tsconfig.json")
configFile := tsoptions.NewTsconfigSourceFileFromFilePath(
configFileName,
fs.CaseSensitivity().PathKey(tspath.RootedPath(configFileName)),
files[configFileName.AsString()],
)

parsed := tsoptions.ParseJsonSourceFileConfigFileContent(
configFile,
tsoptions.NewDefaultParseConfigHost(fs),
"/project",
nil,
nil,
nil,
nil,
)

circularity := core.Filter(parsed.Errors, func(diagnostic *ast.Diagnostic) bool {
return diagnostic.Code() == diagnostics.Circularity_detected_while_resolving_configuration_Colon_0.Code()
})
assert.DeepEqual(t, core.Map(circularity, (*ast.Diagnostic).MessageArgs), [][]string{
{"/project/a.json -> /project/b.json -> /project/a.json"},
})
}

// Extending an empty config file used to panic on nil Statements (#4265).
func TestParseJsonSourceFileConfigFileContentWithEmptyExtendedConfig(t *testing.T) {
t.Parallel()
Expand Down
Loading