Repository navigation
[DO NOT MERGE] Copy of #2793 - #2798
Closed
Xiaoyu Z (xiaoyu-work) wants to merge 2 commits into
Closed
Xiaoyu Z (xiaoyu-work) wants to merge 2 commits into
Xiaoyu Z (xiaoyu-work) wants to merge 2 commits into
Conversation
The AMD CI installed amd-quark==0.10 (test/requirements-test-amd.txt), three releases behind the API the QuarkQuantization pass has used since #2532 (amd-quark>=0.12), so the pass's torch path was never tested against the Quark it targets. Test against the current release, amd-quark 0.13, and make it the pass's minimum (olive_config.json extra, the runtime version gates and their tests, and the docs). Verified with amd-quark 0.13, onnxruntime 1.28, torch 2.13 and transformers 5.15 / 5.22: test/passes/quark_quantizer passes (10 tests), and the pass runs AWQ uint4_wo_128 with a Hugging Face export on a tiny Llama. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Independent, destination-owned copy of #2793: [AMD] Require and test amd-quark 0.13 for QuarkQuantization. Do not merge this draft.
thiagocrepaldi/Olive:quark-0.13microsoft/Olive:quark-0.13main3de106e6f5c0722322eaf4c589c3633900395b8dThe source change raises the
QuarkQuantizationminimum version toamd-quark>=0.13.0and updates the AMD test requirements, runtime version gates, tests, and quantization documentation. Original commits are preserved without edits, and the original PR remains unchanged.Copy verification: the copied branch head matches the source PR head. Tests, model execution, and
lintrunner -awere not run for this copy-only operation; the upstream implementation has not been revalidated.Checklist before requesting a review
lintrunner -a(Optional) Issue link
Original PR: #2793