Skip to content

test: updated the testcases - #1142

Merged
Roopan-Microsoft merged 2 commits into
devfrom
psl-duplicateTeamIssue
Aug 14, 2026
Merged

test: updated the testcases#1142
Roopan-Microsoft merged 2 commits into
devfrom
psl-duplicateTeamIssue

Conversation

@Dhruvkumar-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request adds improved test coverage for the TeamService's save_team_configuration method, specifically ensuring correct behavior when updating an existing team and handling database errors. It also fixes missing mocks in existing tests.

Test coverage improvements

  • Added a new test, test_save_team_configuration_upserts_when_team_exists, which verifies that when a team already exists, save_team_configuration updates the existing team, preserves immutable fields, and does not call add_team.

Test reliability fixes

  • Updated existing tests to mock get_team in the test context, ensuring that tests do not depend on unmocked calls and behave deterministically. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL383255285% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
835 0 💤 0 ❌ 0 🔥 9.775s ⏱️

@Roopan-Microsoft
Roopan-Microsoft merged commit ee285e8 into dev Aug 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants