test: updated the testcases - #1142
Merged
Merged
Conversation
Roopan-Microsoft
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request adds improved test coverage for the
TeamService'ssave_team_configurationmethod, specifically ensuring correct behavior when updating an existing team and handling database errors. It also fixes missing mocks in existing tests.Test coverage improvements
test_save_team_configuration_upserts_when_team_exists, which verifies that when a team already exists,save_team_configurationupdates the existing team, preserves immutable fields, and does not calladd_team.Test reliability fixes
get_teamin the test context, ensuring that tests do not depend on unmocked calls and behave deterministically. [1] [2]Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information