refactor: update credential retrieval logic based on environment - #1126
Merged
Conversation
Roopan-Microsoft
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the logic for obtaining Azure credentials in the
image_service.pyservice to better distinguish between development and production environments. The main change is to select the credential type based on theAPP_ENVenvironment variable, improving local development experience and deployment flexibility.Credential selection improvements:
_get_credentialfunction inimage_service.pyto useDefaultAzureCredentialwithrequire_envvar=TruewhenAPP_ENVis set todev, and to useManagedIdentityCredentialwith the configured client ID otherwise. This ensures that local development uses environment-based credentials, while production uses managed identity.osmodule to support reading environment variables.Does this introduce a breaking change?
Other Information
This pull request updates the logic for obtaining Azure credentials in the
image_service.pyto better support different environments (development vs. production). The main change is to select the appropriate credential type based on theAPP_ENVenvironment variable.Credential selection improvements:
_get_credentialfunction to check theAPP_ENVenvironment variable and useDefaultAzureCredentialin development environments andManagedIdentityCredentialin production, improving environment-specific authentication handling.import osto support reading environment variables for credential selection.