Fix nullable typeof expressions in custom property providers - #2558
Open
Sergio Pedri (Sergio0694) wants to merge 3 commits into
Open
Fix nullable typeof expressions in custom property providers#2558Sergio Pedri (Sergio0694) wants to merge 3 commits into
Sergio Pedri (Sergio0694) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Sergio Pedri (Sergio0694)
requested a review
from Manodasan Wignarajah (manodasanW)
September 11, 2026 11:13
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sergio Pedri (Sergio0694)
enabled auto-merge (squash)
September 11, 2026 11:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
GeneratedCustomPropertyProvideremitting nullable reference annotations intypeofexpressions for property descriptors and indexer lookup. Retain annotations in casts and preserve nullable value types.Motivation
Valid nullable binding models currently fail to compile with CS8639 because the generator emits expressions such as
typeof(string?)andtypeof(object?). Runtime type lookup must omit nullable reference annotations without strippingNullable<T>or changing init-only setter behavior.Changes
src\Authoring\WinRT.SourceGenerator2\CustomPropertyProviderGenerator.Execute.csandsrc\Authoring\WinRT.SourceGenerator2\Models\CustomPropertyInfo.cs: carry separate Roslyn-formatted names fortypeofoperands alongside the existing nullable-annotated cast names.src\Authoring\WinRT.SourceGenerator2\CustomPropertyProviderGenerator.Emit.cs: use the runtime-type names for ordinary and indexed property descriptors and indexer parameter matching.src\Tests\SourceGenerator2Test\Test_CustomPropertyProviderGenerator.cs: add 18 compilation-based and runtime regression cases covering nullable strings, objects, arrays, generics, structs, and tuples under automatic discovery and explicit selection. Assert descriptor type identity, null round-trips, getter/setter behavior, and read-only init properties.