Fix incremental PR builds affected by baseline drift - #2361
Draft
Alexander Holstrup (aholstrup1) wants to merge 2 commits into
Draft
Fix incremental PR builds affected by baseline drift#2361Alexander Holstrup (aholstrup1) wants to merge 2 commits into
Alexander Holstrup (aholstrup1) wants to merge 2 commits into
Conversation
Use the pull request merge-base to decide whether anything or everything must be built, while retaining the successful workflow baseline for safe artifact reuse. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6bb9e482-1543-411e-9fb4-f316a810139d
Rename baseline-oriented variables and the Get-ProjectsToBuild parameter while retaining modifiedFiles as a compatibility alias. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6bb9e482-1543-411e-9fb4-f316a810139d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❔What, Why & How
Incremental pull request builds currently use the last successful target-branch build for both change detection and artifact reuse. On busy branches, this attributes changes merged after that baseline to the pull request, potentially triggering
fullBuildPatternsand building everything for an otherwise unrelated PR.This separates those decisions:
fullBuildPatternsrequires all projects or apps to be built.A shared
Test-IsPullRequesthelper is used for PR event handling.Related work item: AB#647482
Related to issue: N/A
✅ Checklist