Escape tags and emphasis in the download summary's prose - #135
Merged
Conversation
A dropped translation's reason names the placeholders and tags that differ, so "missing <li>, <p>, <ul>" reached the pull request body as HTML and rendered as an empty list. The reasons and download errors are now backslash-escaped; the ids and message texts were already code spans. Code spans are fenced with more backticks than any run inside them, since a backslash does not escape within a span.
Deploying ui with
|
| Latest commit: |
f85cf57
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://65a8a5a3.ui-2wg.pages.dev |
| Branch Preview URL: | https://summary-escaping.ui-2wg.pages.dev |
Contributor
Author
|
Comical PR: microbit-foundation/python-editor-v3#1310 Amusingly, the exact same rendering is in the description of this one from the commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dropped translation's reason names the placeholders and tags that differ, so "missing
,
" reached the pull request body as HTML and rendered as an empty list. The reasons and download errors are now backslash-escaped; the ids and message texts were already code spans.
Code spans are fenced with more backticks than any run inside them, since a backslash does not escape within a span.