Repository navigation
feat(rbac): report:import and signatory:read|manage for partner-lab imports (1.4.0) - #12
Merged
Merged
Conversation
…mports (1.4.0) The api imports partner-lab PDF reports (report-reader) and keeps a registry of partner signatures. New permissions, following the resource:action form so role wildcards cover them: - report:import — upload a partner PDF, match it to a booking, apply its results - signatory:read — list the partner signature registry - signatory:manage — name a partner signature, edit or remove one admin (report:*, signatory:*), pathologist (report:*, signatory:*) and technician (report:import, signatory:read) get them. Tests, README and llms-full.txt updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018jBohmYiwjQLWmN2duiZcA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Himanshu · project thread
What and why
The api is getting partner-lab PDF imports (report-reader: Hy Patho Lab, Clinova Pathlabs). Every permission the api checks must exist in
PERMISSIONS, so this adds:report:importadmin,pathologist(viareport:*),techniciansignatory:readadmin,pathologist,techniciansignatory:manageadmin,pathologistThe brief called them
reports.import/signatories.manage. They are written here in this kit'sresource:actionform, becausepermissionMatchessplits on:. A dotted name would never match role wildcards likereport:*. Imported results still needreport:verifybefore release. That part is unchanged.Version 1.4.0 (new permissions, nothing renamed).
Type
Checklist
npm run typecheckpassesnpm test: 131 passed, 0 failed (3 new rbac checks)Generated by Claude Code