Repository navigation
feat(client): drop the deprecated building block shapes - #36
Merged
Merged
Conversation
grubmeshi
force-pushed
the
feature/make-bb-bbd-ga
branch
from
October 14, 2026 08:41
150da74 to
21849ca
Compare
|
Coverage of the acceptance run against the meshStack backend, on
Uncovered functions
|
grubmeshi
force-pushed
the
feature/make-bb-bbd-ga
branch
from
October 14, 2026 10:51
5c2ccf0 to
c99b890
Compare
grubmeshi
marked this pull request as ready for review
October 14, 2026 10:53
j0g3sc
approved these changes
Oct 19, 2026
grubmeshi
force-pushed
the
feature/make-bb-bbd-ga
branch
2 times, most recently
from
October 26, 2026 07:28
4ccd1dc to
78d9b1d
Compare
grubmeshi
force-pushed
the
feature/make-bb-bbd-ga
branch
4 times, most recently
from
October 29, 2026 14:08
07f2c14 to
d2c5dcc
Compare
grubmeshi
force-pushed
the
feature/make-bb-bbd-ga
branch
2 times, most recently
from
November 4, 2026 19:01
8796b47 to
09cee56
Compare
grubmeshi
force-pushed
the
feature/make-bb-bbd-ga
branch
from
November 4, 2026 21:31
09cee56 to
b86a5d1
Compare
The meshBuildingBlock client sends the parents in spec.parentBuildingBlockRefs alone, which every meshStack from MinMeshStackVersion on reads, so the client drops the deprecated parentBuildingBlocks field and its MarshalJSON and UnmarshalJSON. The v1 building block client (client.BuildingBlock, MeshBuildingBlock and its DTOs) goes as well: only the Terraform provider's removed meshstack_buildingblock resource used it. The client no longer reads the deprecated status.status and drops the status list filter: it drops BuildingBlockStatus, the Status field of MeshBuildingBlockV2Status and MeshBuildingBlockV2ListFilter.Status. Callers read status.action. MeshBuildingBlockRun.IsRunning takes over the run status check of the tfstate lock. The clients keep the v2-preview and v1-preview media types, so they work against the current meshStack and against the release that makes these APIs GA. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lues The custom JSON methods implement json/v2's MarshalJSONTo and UnmarshalJSONFrom, which receive the options of the encoder or decoder. The options internal/json marshals every request with now reach a nested value on their own, so the client and the variant package no longer keep copies of them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
One depguard rule over all files denies exactly encoding/json, so the per-package rules no longer repeat that deny. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
grubmeshi
force-pushed
the
feature/make-bb-bbd-ga
branch
from
November 5, 2026 10:03
b86a5d1 to
9bcaa5f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Removes the deprecated building block shapes from the client. meshcloud/terraform-provider-meshstack#274 uses this branch.
client.BuildingBlock,MeshBuildingBlockand its DTOs).parentBuildingBlocksfield. Parents go inparentBuildingBlockRefsalone.status.statusand thestatuslist filter. The tfstate lock usesMeshBuildingBlockRun.IsRunning().v2-previewandv1-previewmedia types. This works against the current meshStack and needs no newer release;MinMeshStackVersionstays2026.36.0.Review it commit by commit:
feat(client)removes the deprecated shapes.refactor(client)moves the custom JSON methods to json/v2'sMarshalJSONToandUnmarshalJSONFrom, so nested values get the caller's options and the copies of those options go.chore(lint)replaces the per-package denies ofencoding/jsonwith one rule over all files.🤖 Generated with Claude Code